Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tracing Fix async Task Handler exception #675

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Oct 31, 2024

Please provide the issue number

Issue number: #674

Summary

Changes

  • Remove dependency on IMethodAspectHandler
  • Improve async and non async aspect
  • Add WithTracing extension method for PowertoolsSourceGeneratorSerializer (SourceGeneratorLambdaJsonSerializer) (AOT)
  • Add PowertoolsTracingSerializer to serialize metadata from client models (AOT)

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig October 31, 2024 09:55
@boring-cyborg boring-cyborg bot added area/metrics Core metrics utility area/tracing Core tracing utility tests labels Oct 31, 2024
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 31, 2024
@github-actions github-actions bot added the internal Maintenance changes label Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 97.80220% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.29%. Comparing base (81acc01) to head (e304c48).
Report is 19 commits behind head on develop.

Files with missing lines Patch % Lines
...ambda.Powertools.Tracing/Internal/TracingAspect.cs 96.96% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #675      +/-   ##
===========================================
- Coverage    73.48%   73.29%   -0.19%     
===========================================
  Files          197      200       +3     
  Lines         8043     8103      +60     
  Branches       860      871      +11     
===========================================
+ Hits          5910     5939      +29     
- Misses        1847     1875      +28     
- Partials       286      289       +3     
Flag Coverage Δ
unittests 73.29% <97.80%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…generator. add dependency Amazon.Lambda.Serialization.SystemTextJson
@hjgraca hjgraca force-pushed the fix(tracing)-aot-void-task-and-serialization branch from ccea4da to 5bc2000 Compare October 31, 2024 13:02
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Oct 31, 2024
Copy link

sonarcloud bot commented Nov 6, 2024

@hjgraca hjgraca merged commit 46d5b86 into aws-powertools:develop Nov 12, 2024
7 of 8 checks passed
@hjgraca hjgraca deleted the fix(tracing)-aot-void-task-and-serialization branch November 12, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Core metrics utility area/tracing Core tracing utility documentation Improvements or additions to documentation internal Maintenance changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants